-
-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve docs on how ParallaxLayer mirroring works. #80896
Improve docs on how ParallaxLayer mirroring works. #80896
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As expressed on your original PR this feels too big to fit in this section, and belongs in a tutorial in my opinion
Thanks for reviewing.
I believe the reference docs should be the complete and authoritative source of information. I.e. an official tutorial should bring no more information than what you can piece together from the references. Of all I wrote, I think only this paragraph doesn't bring novel information important to the
But even then, I don't think such an usage tip is out of place in a reference documentation: the reference should be more complete and thorough on the details than a tutorial, not less. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some style and grammar pointers
Unsure about the verbosity but some good pointers, I think some of the details might be best served in a detailed tutorial explaining things with examples, but works here as well
Sorry for the long delay. I applied all the fixes, thanks. |
7d50c89
to
996714c
Compare
996714c
to
7d50c89
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo
How can CI fail in building C++ code if I didn't touch it? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Neat details to a class that may have desperately needed some, although perhaps it's a little too much. I have reviewed this just when a new Parallax2D node is being in the works so this may be a bit obsolete, but it is nice nonetheless.
I wrote everything I wish was written when I tried to make an infinite scrolling background, addressing every point of every mistake I made.
e8c9c0b
to
40813b6
Compare
Committed @Mickeon's suggestions and squashed the commits. |
Thanks! And congrats for your first merged Godot contribution 🎉 |
Cherry-picked for 4.2.2. |
I wrote everything I wish was written when I tried to make an infinite scrolling background, addressing every point of every mistake I made.